fix: added configurable connection pool support for mssql #38818
Conversation
WalkthroughThe pull request introduces enhanced configurability for the MSSQL plugin's connection pool management. By integrating a Changes
Sequence DiagramsequenceDiagram
participant Executor as MssqlPluginExecutor
participant Config as ConnectionPoolConfig
participant DataSource as HikariDataSource
Executor->>Config: getMaxConnectionPoolSize()
Config-->>Executor: Mono<Integer> maxPoolSize
Executor->>DataSource: createConnectionPool(config, maxPoolSize)
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java (1)
Line range hint
575-590: Add input validation for maxPoolSizeWhile the implementation is correct, consider adding validation to ensure maxPoolSize is not negative or unreasonably large.
private static HikariDataSource createConnectionPool( DatasourceConfiguration datasourceConfiguration, Integer maxPoolSize) throws AppsmithPluginException { + if (maxPoolSize != null && maxPoolSize <= 0) { + throw new AppsmithPluginException( + AppsmithPluginError.PLUGIN_DATASOURCE_ARGUMENT_ERROR, + "Maximum pool size must be greater than 0"); + } // ... rest of the method
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java(5 hunks)app/server/appsmith-plugins/mssqlPlugin/src/test/java/com/external/plugins/MssqlTestDBContainerManager.java(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: perform-test / client-build / client-build
- GitHub Check: perform-test / rts-build / build
- GitHub Check: server-spotless / spotless-check
- GitHub Check: server-unit-tests / server-unit-tests
🔇 Additional comments (4)
app/server/appsmith-plugins/mssqlPlugin/src/test/java/com/external/plugins/MssqlTestDBContainerManager.java (2)
23-28: LGTM - Mock implementation is clean and focusedThe mock implementation provides a clear, single-responsibility test double for connection pool configuration.
30-31: LGTM - Proper initialization with mock configThe static executor is correctly initialized with the mock connection pool configuration.
app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java (2)
118-122: LGTM - Clean dependency injection patternThe connection pool configuration is properly injected through constructor, following good dependency injection practices.
366-372: LGTM - Well-structured reactive flowThe datasource creation properly handles the async nature of pool size configuration using reactive patterns.
Failed server tests
|
Description
With current implementation, MSSQL is configured with HikariCP to have maximum pool size of 10. But this means that if multiple concurrent users are accessing multiple queries of the same datasource at the same time, some of the queries might time out due to max pool size of 10. We have encountered this issue in https://theappsmith.slack.com/archives/C0341RERY4R/p1736150680663059. Where 40-50 concurrent users are simultaneously making 20-30 queries to MSSQL database.
This PR makes this connection pool size configurable from admin settings for MSSQL as well.
Fixes #https://github.com/appsmithorg/appsmith-ee/issues/5928
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12925650660
Commit: ebda936
Cypress dashboard.
Tags:
@tag.AllSpec:
Thu, 23 Jan 2025 11:18:35 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Improvements
Tests