Update scrolled_mobile.html #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sH.innerHTML = document.documentElement.scrollHeight + " px"; | ||
| cW.innerHTML = document.documentElement.clientWidth + " px"; | ||
| cH.innerHTML = document.documentElement.clientHeight + " px"; | ||
| // recheck the final 'scrollWidth' to ensure it was not changed |
Collaborator
There was a problem hiding this comment.
Suggested change
| // recheck the final 'scrollWidth' to ensure it was not changed | |
| // re-check the final 'scrollWidth' to ensure it was not changed |
Contributor
Author
There was a problem hiding this comment.
@Tal-applitool this is such an old PR, can't even say what was done there and whether it's relevant at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is relevant for cases of narrow screens (e.g. mobile), it causes the value of
documentElement.scrollWidthto be wrong since the code of calculation and placement (aka:innerHTML) is actually changing the width by itself.This fix makes sure to set the actual width value in case the firstly calculated width is not the actual width.
re-calling the method
updateData()twice will also result the correct width.