Expose jwt-go MapClaims through gin-jwt. #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
MapClaimsstruct to be an alias of the golang-jwt library's MapClaims instead of requiring all the downstream functions to use thegolang-jwtlibrary's struct.This helps a lot with breaking changes (such as the one introduced in the last tag) because it means that the function inputs can be consistent, and it prevents anyone who uses
MapClaimsin upstream code from needing to importgolang-jwtin any of their packages. This is important because requiring users to import golang-jwt directly can cause version mismatches when trying to manage dependencies.