Skip to content

docs: Delete instructions to run non-existent soundness.sh #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

euanh
Copy link
Contributor

@euanh euanh commented Apr 16, 2025

Motivation

scripts/soundness.sh was deleted in #604 which moved CI to GitHub Actions.

Credit to @heckj, who found the same problem in apple/swift-container-plugin#96.

Modifications

Remove the instruction to run scripts/soundness.sh from CONTRIBUTING.md.

Result

Documentation no longer refers to nonexistent scripts.

Test Plan

No functional change.

scripts/soundness.sh was deleted in apple#604 which moved CI to GitHub Actions.

Credit to @heckj, who found the same problem in apple/swift-container-plugin#96.
@simonjbeaumont simonjbeaumont merged commit 28a4629 into apple:main Apr 16, 2025
37 of 38 checks passed
@euanh euanh deleted the remove-soundness-check-docs branch April 17, 2025 11:25
@simonjbeaumont simonjbeaumont added the semver/none No version bump required. label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants