Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neighbors -> Neighbor in PNNS #13

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Neighbors -> Neighbor in PNNS #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apple/swift_homomorphic_encryption/api/pnns/v1/pnns.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ message PNNSConfig {
apple.swift_homomorphic_encryption.pnns.v1.MatrixPacking query_packing = 3;
// Number of entries in each vector.
uint32 vector_dimension = 4;
// Metric for similarity computation.
// Metric for computing distances.
apple.swift_homomorphic_encryption.pnns.v1.DistanceMetric distance_metric = 5;
// hash of EvaluationKeyConfig.
bytes evaluation_key_config_hash = 6;
Expand Down
2 changes: 1 addition & 1 deletion apple/swift_homomorphic_encryption/pnns/v1/pnns_client_config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ message ClientConfig {
MatrixPacking query_packing = 3;
// Number of entries in each vector.
uint32 vector_dimension = 4;
// Galois elements required for nearest neighbors computation.
// Galois elements required for nearest neighbor search.
repeated uint32 galois_elements = 5;
// Metric for distances between vectors.
DistanceMetric distance_metric = 6;
Expand Down
6 changes: 3 additions & 3 deletions apple/swift_homomorphic_encryption/pnns/v1/pnns_database.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@
syntax = "proto3";
package apple.swift_homomorphic_encryption.pnns.v1;

// Row in a private nearest neighbors search database.
// Row in a private nearest neighbor search database.
message DatabaseRow {
// Unique identifier for the database entry.
uint64 entry_id = 1;
// Metadata associated with the entry.
bytes entry_metadata = 2;
// Vector for use in nearest neighbors computation.
// Vector for use in nearest neighbor search.
repeated float vector = 3;
}

// A private nearest neighbors search database.
// A private nearest neighbor search database.
message Database {
// Rows in the database.
repeated DatabaseRow rows = 1;
Expand Down
4 changes: 2 additions & 2 deletions apple/swift_homomorphic_encryption/pnns/v1/pnns_processed_database.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ package apple.swift_homomorphic_encryption.pnns.v1;
import "apple/swift_homomorphic_encryption/pnns/v1/pnns.proto";
import "apple/swift_homomorphic_encryption/pnns/v1/pnns_server_config.proto";

// Serialized pre-processed nearest neighbors database.
// Serialized pre-processed nearest neighbor database.
message SerializedProcessedDatabase {
// Pre-computed values for the nearest neighbors computation, one per plaintext CRT modulus.
// Pre-computed values for the nearest neighbor search, one per plaintext CRT modulus.
repeated SerializedPlaintextMatrix plaintext_matrices = 1;
// Unique identifier for each entry in the database.
repeated uint64 entry_ids = 2;
Expand Down