Use LockedValueBoxes for state protection #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The old lock used is deprecated. Modifications: Move to using NIOLockedValueBox Result: No deprecation warnings
Lukasa
reviewed
Oct 28, 2024
| } | ||
| switch state { | ||
| case .connected: | ||
| try self.disconect() |
There was a problem hiding this comment.
I'm pretty nervous about this function being called with the lock held.
| switch self.state { | ||
| let (startingState, future) = self.stateStore.withLockedValue { (state: inout State) -> (State, EventLoopFuture<Void>?) in | ||
| if case .idle = state { | ||
| let future = self.connect(on: eventLoop, logger: logger) |
| lock.unlock() | ||
| let (startingState, task) = self.stateStore.withLockedValue { (state: inout State) -> (State, Task<Void, Swift.Error>?) in | ||
| if case .idle = state { | ||
| let task = self.connect(logger: logger) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The old lock used is deprecated.
Modifications:
Move to using NIOLockedValueBox
Result:
No deprecation warnings