Skip to content

feat: Take down steep issues from 522 to 104 #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
afdc4ca
Take down steep issues from 522 to 427
aguspe Aug 3, 2024
2093701
Small type update done
aguspe Aug 4, 2024
423767a
Merge branch 'master' into add_rbs_support_for_driver
aguspe Sep 6, 2024
1ee9b23
Take down steep issues from 522 to 304
aguspe Sep 14, 2024
5a98218
Merge remote-tracking branch 'origin/add_rbs_support_for_driver' into…
aguspe Sep 14, 2024
845177a
Take down steep issues from 522 to 286
aguspe Sep 14, 2024
0e82f5c
Take down steep issues from 522 to 268
aguspe Sep 15, 2024
f2538c4
Take down steep issues from 522 to 198
aguspe Sep 15, 2024
26b998d
Take down steep issues from 522 to 176
aguspe Sep 15, 2024
a301e45
Take down steep issues from 522 to 168
aguspe Sep 15, 2024
59a6f19
Take down steep issues from 522 to 165
aguspe Sep 15, 2024
79cc58c
take down to 104 problems to 30 files
aguspe Sep 25, 2024
1fc1122
Reduce issues to 96
aguspe Nov 3, 2024
5eb47d8
Reduce issues to 95
aguspe Nov 3, 2024
a936fe9
Merge branch 'master' into add_rbs_support_for_driver
aguspe Jan 1, 2025
a65cfc2
Reduce errors from 105 to 99
aguspe Jan 1, 2025
3057503
Merge remote-tracking branch 'origin/add_rbs_support_for_driver' into…
aguspe Jan 1, 2025
9e037e0
Reduce errors from 105 to 99
aguspe Feb 16, 2025
974ee34
Merge master
aguspe Apr 6, 2025
2055333
Uncomment and update unit test workflow
KazuCocoa Apr 7, 2025
3463968
Reformat unittest.yml indentation
KazuCocoa Apr 7, 2025
98ca989
Update Ruby versions in CI workflow
KazuCocoa Apr 7, 2025
9f19fe2
Fix indentation for test-win job in workflow
KazuCocoa Apr 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/appium_lib_core/common/device/app_management.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def background_app(duration = 0)

def install_app(path, options = {})
args = { appPath: path }
args[:options] = options unless options.empty?
args[:options] = options unless options&.empty?

execute :install_app, {}, args
end
Expand Down
5 changes: 5 additions & 0 deletions sig/gems/em.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module EM
def stop: () -> untyped

def run: () -> untyped
end
10 changes: 10 additions & 0 deletions sig/gems/faye.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
module Faye
module WebSocket
class Client
def initialize: (String, String, Hash[Symbol, untyped]) -> void
def close: () -> void
def send: (String) -> void
def on: (String, Proc) -> void
end
end
end
16 changes: 16 additions & 0 deletions sig/gems/selenium/atoms.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
module Selenium
module WebDriver
module Atoms
include _Bridge
include _ExecuteScript

def atom_script: (Symbol) -> String

private

def read_atom: (Symbol function) -> String

def execute_atom: (Symbol function_name, [Element | String | Symbol] arguments) -> [Element | Integer | Float | bool | nil | String | Array[untyped]]
end
end
end
27 changes: 27 additions & 0 deletions sig/gems/selenium/bidi/browsing_context.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
module Selenium
module WebDriver
class BiDi
class BrowsingContext
@bidi: untyped

@id: untyped

attr_accessor id: untyped

READINESS_STATE: Hash[Symbol, String]

def initialize: (driver: untyped, ?browsing_context_id: untyped?, ?type: untyped?, ?reference_context: untyped?) -> void

def navigate: (url: untyped, ?readiness_state: untyped?) -> untyped

def get_tree: (?max_depth: untyped?) -> untyped

def close: () -> untyped

private

def create: (untyped type, untyped reference_context) -> untyped
end
end
end
end
25 changes: 25 additions & 0 deletions sig/gems/selenium/bidi/browsing_context_info.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
module Selenium
module WebDriver
class BiDi
class BrowsingContextInfo
@id: untyped

@url: untyped

@children: untyped

@parent_browsing_context: untyped

attr_accessor id: untyped

attr_accessor url: untyped

attr_accessor children: untyped

attr_accessor parent_browsing_context: untyped

def initialize: (id: untyped, url: untyped, children: untyped, parent_context: untyped) -> void
end
end
end
end
33 changes: 33 additions & 0 deletions sig/gems/selenium/bidi/log_inspector.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
module Selenium
module WebDriver
class BiDi
class LogInspector
@bidi: untyped

EVENTS: Hash[Symbol, String]

LOG_LEVEL: Hash[Symbol, String]

def initialize: (untyped driver, ?untyped? browsing_context_ids) -> void

def on_console_entry: (?untyped? filter_by) { () -> untyped } -> untyped

def on_javascript_log: (?untyped? filter_by) { () -> untyped } -> untyped

def on_javascript_exception: () { () -> untyped } -> untyped

def on_log: (?untyped? filter_by) { (untyped) -> untyped } -> untyped?

private

def on: (untyped event) { () -> untyped } -> untyped

def check_valid_filter: (untyped filter_by) -> (nil | untyped)

def console_log_events: (untyped params, untyped filter_by) { (untyped) -> untyped } -> untyped?

def javascript_log_events: (untyped params, untyped filter_by) { (untyped) -> untyped } -> untyped?
end
end
end
end
17 changes: 17 additions & 0 deletions sig/gems/selenium/bidi/navigate_result.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
module Selenium
module WebDriver
class BiDi
class NavigateResult
@url: untyped

@navigation_id: untyped

attr_accessor url: untyped

attr_accessor navigation_id: untyped

def initialize: (url: untyped, navigation_id: untyped) -> void
end
end
end
end
19 changes: 19 additions & 0 deletions sig/gems/selenium/bidi/session.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
module Selenium
module WebDriver
class BiDi
class Session
@bidi: untyped

Status: untyped

def initialize: (untyped bidi) -> void

def status: () -> untyped

def subscribe: (untyped events, ?untyped? browsing_contexts) -> untyped

def unsubscribe: (untyped events, ?untyped? browsing_contexts) -> untyped
end
end
end
end
Loading
Loading