Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unclosed file <_io.BufferedReader name error by proper cleanup of subprocess.Popen process #965

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

WrrngnCode
Copy link
Contributor

#962

After self._process.terminate() a call to Popen.communicate()](https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate) shall be made, which will close the file handles.
This will ensure that file stdout and sdterr file descriptors are closed properly.

appium#962
add a Popen.communicate call after terminate to ensure that file stdout and sdterr file descriptors are closed properly.
Copy link

linux-foundation-easycla bot commented Feb 24, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@WrrngnCode WrrngnCode changed the title Update appium_service.py fix unclosed file <_io.BufferedReader name error by proper cleanup of subprocess.Popen process Feb 24, 2024
@KazuCocoa KazuCocoa changed the title fix unclosed file <_io.BufferedReader name error by proper cleanup of subprocess.Popen process fix: unclosed file <_io.BufferedReader name error by proper cleanup of subprocess.Popen process Feb 24, 2024
@KazuCocoa KazuCocoa merged commit ac9965d into appium:master Feb 24, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants