chore: inherit CanFindElements #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds CanFindElements protocol inheritance to both the WebElement and WebDriver classes to provide consistent element finding capabilities across the Appium webdriver implementation.
- Adds
CanFindElementsprotocol inheritance toWebElementclass - Adds
CanFindElementsprotocol inheritance toWebDriverclass
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| appium/webdriver/webelement.py | Inherits from CanFindElements protocol and adds the necessary import |
| appium/webdriver/webdriver.py | Adds CanFindElements to the multiple inheritance chain and imports the protocol |
KazuCocoa
changed the title
mykola-mokhnach
approved these changes
Jul 24, 2025
KazuCocoa
added a commit
that referenced
this pull request
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.