fix: add backgroundApp #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/driver.ts
Outdated
| @@ -413,6 +413,7 @@ class AndroidDriver | |||
| activateApp = activateApp; | |||
| queryAppState = queryAppState; | |||
| isAppInstalled = isAppInstalled; | |||
| mobileBackgroundApp = background; | |||
There was a problem hiding this comment.
mobileBackgroundApp and background definitions are not the same. mobileBackgroundApp sets the background argument to -1 by default, which changes the behavior
There was a problem hiding this comment.
That's right (default one)
There was a problem hiding this comment.
added as a new mobile command: 2a847cf
|
I assume after this update is published we don't need to do anything explicit in espresso driver except of the package bump. For UIA2 though we'd need to remove duplicated method definitions. |
mykola-mokhnach
approved these changes
Mar 17, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 17, 2025
## [10.2.3](v10.2.2...v10.2.3) (2025-03-17) ### Bug Fixes * add backgroundApp ([#988](#988)) ([a6424cc](a6424cc))
|
🎉 This PR is included in version 10.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Espresso driver missed this background app right now.
https://github.com/appium/appium-espresso-driver?tab=readme-ov-file#mobile-backgroundapp
Past implementation in espresso driver is the same as uia2's one, so this android driver can have it and both drivers refer to this.
I'll remove uia2's current method as redundant after this