support reboot parameter for android #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alizelzele
force-pushed
the
reboot-emulator
branch
from
be8b47d to
01ceefd
Compare
9 tasks
| log.info('avd name defined, ignoring device name and platform version'); | ||
| } else { | ||
| if (!caps.deviceName) { | ||
| log.errorAndThrow('avd or deviceName should be specified when reboot option is enables'); |
|
This looks good to me, though I would prefer to have the logic pulled out into an appropriately-named method, for clarity. |
If reboot option activated, it will always wipe data of emulator on start, and close emulator at the end, It also use device name and platform version to create avd name, if it is not defined.
alizelzele
force-pushed
the
reboot-emulator
branch
from
01ceefd to
6be8e06
Compare
|
@imurchie Divided reboot code into two method, and fixed typo. |
|
Looks good to me! Thanks for this! |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If reboot option activated (will link pull request for that soon), it will always wipe data of emulator on start, and close emulator at the end.
It also use device name and platform version to create avd name, if it is not defined.
Android emulator sometimes get stuck if it is started for a long time without activity, and will not respond to any adb command, even if we kill adb-server, this update will kill emulator after session and wipe it on start to reduce the risk of this problem on production. the issue was already created about it. #167