fix: make runUntilDate not system aware #1050
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #1045 |
|
Could you please describe the purpose of this PR and the problem it solves? |
mykola-mokhnach
changed the title
…om/codeskyblue/WebDriverAgent into fix_stuck_when_system_time_changes
| #import <Foundation/Foundation.h> | ||
|
|
||
| @interface NSRunLoop (Monotonic) | ||
| - (void)runForMonotonicInterval:(NSTimeInterval)seconds; |
There was a problem hiding this comment.
Could you please add a docstring to the public interface method?
mykola-mokhnach
approved these changes
Aug 15, 2025
mykola-mokhnach
changed the title
KazuCocoa
approved these changes
Aug 15, 2025
KazuCocoa
reviewed
Aug 16, 2025
KazuCocoa
reviewed
Aug 16, 2025
| - (void)runForMonotonicInterval:(NSTimeInterval)seconds { | ||
| CFTimeInterval end = CACurrentMediaTime() + seconds; | ||
| while (CACurrentMediaTime() < end) { | ||
| [self runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantFuture]]; |
There was a problem hiding this comment.
Can your issue be resolved with:
Suggested change
| [self runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantFuture]]; | |
| [self runMode:NSRunLoopCommonModes beforeDate:[NSDate distantFuture]]; |
It looks like the default mode could block some actions such as UI tracking. I observed this blocking behavior in testGetPasteboard's fb_typeText method for example. It caused many timeouts in tests (e.g. https://dev.azure.com/AppiumCI/Appium%20CI/_build/results?buildId=30265&view=results).
https://stackoverflow.com/questions/7222449/nsdefaultrunloopmode-vs-nsrunloopcommonmodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.