forked from facebookarchive/WebDriverAgent
-
Notifications
You must be signed in to change notification settings - Fork 442
feat: add minimum and maximum value attributes to page source #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KazuCocoa
merged 6 commits into
appium:master
from
ikharebashviliGD:feat/add-min-and-max-value-attributes
Jun 9, 2025
Merged
feat: add minimum and maximum value attributes to page source #1031
KazuCocoa
merged 6 commits into
appium:master
from
ikharebashviliGD:feat/add-min-and-max-value-attributes
Jun 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
reviewed
Jun 7, 2025
ikharebashviliGD
commented
Jun 9, 2025
mykola-mokhnach
approved these changes
Jun 9, 2025
KazuCocoa
approved these changes
Jun 9, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
## [9.14.0](v9.13.0...v9.14.0) (2025-06-09) ### Features * add minimum and maximum value attributes to page source ([#1031](#1031)) ([0e4e7e7](0e4e7e7))
🎉 This PR is included in version 9.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
minValue
andmaxValue
attributes using private XCTest APIs.Motivation
These attributes are important for elements like sliders and steppers, where they define the valid input range. Including them allows better validation, debugging, and automation for range-based UI components.
Implementation Notes
_XC_kAXXCAttributeMinValue
and_XC_kAXXCAttributeMaxValue
.XCUIElementTypeSlider
,XCUIElementTypeStepper
).