Add type check to validation job

appinfosapienza · Jun 14, 2024 · 7650531 · 7650531
1 parent 5b49781
commit 7650531
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/scripts/validate_questions.py b/scripts/validate_questions.py
@@ -22,11 +22,12 @@
                     raise Exception(str(data.index(q)) + ": Question has no answers.")
 
                 for a in q["answers"]:
-                    if a["text"] == "" and a["image"] == "":
-                        raise Exception(str(data.index(q)) + ": Answer's text and image cannot both be empty.")
                     if type(a["text"]) is not str or type(a["image"]) is not str:
                         raise Exception(str(data.index(q)) + ": Some answer's parameters are null, missing or their type is wrong.")
 
+                    if a["text"] == "" and a["image"] == "":
+                        raise Exception(str(data.index(q)) + ": Answer's text and image cannot both be empty.")
+
         except Exception as e:
             logging.error(getattr(e, 'message', repr(e)))
             logging.fatal(filename + " is invalid. Aborting.")