fix: pin native benchmark compatibility adapters - #483
Merged
Merged
Conversation
Collaborator
Author
|
Fresh code re-review is clear at d5c62f1; all 9 focused live compatibility/isolation tests passed. Campaign use remains gated on fresh golden state and an untimed build, launch-error recovery, recording and cleanup smoke with the exact RC.21 manifest and isolation profile. |
janicduplessis
marked this pull request as ready for review
September 7, 2026 21:20
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The isolated iOS recovery benchmark cannot finish recording when agent-device's process inspection is denied, and ExpoModulesJSI's nested SwiftPM sandbox blocks its build. Refs #469; the real campaign build/recording/cleanup preflight remains outstanding before timed runs.
Solution
Prepare a hash-pinned local copy of agent-device 0.20.10 with the native process helper from the upstream fix, plus an explicit Xcode/JSI sandbox adapter. Both arms use the same copies; the outer benchmark isolation stays enforced. Unknown package bytes or later mutations fail validation.
This is benchmark-only compatibility, not a global install change. It adds a Node process per process query; new campaigns require fresh golden state and exact-toolchain preflight.
Test plan
psis denied while identity lookup works, and verifies Xcode resolves through the pinned wrapper.