SECOPS-2268: Add Gitleaks to CI #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure that I've changed anything that would cause the build steps to fail? 🤔 Happy to do anything I can to make this mergeable! |
|
hi @peakematt so sorry for the serious delay - is this still needed? |
|
@peakematt is this superseded by #51 and can I close this out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Implements
This PR updates
.circleci/config.ymlto configure Gitleaks to run on PRs on this repo. The Apollo Security team uses Gitleaks to test our repositories for secrets.Once this is accepted and merged, the Security team plans to make a passing Gitleaks check a requirement for PRs to merge into this repo. This will prevent secrets from being introduced to our repos.
In the event that a secret is detected on a repo, the CI job will add a comment to the PR associated with the detection to provide instructions on how to properly resolve the detection. Additionally, if a secret is detected, the Apollo Security team will be notified so that we can be available to assist in resolving the detection.
If maintainers reviewing this PR have questions, please see this Apollo-internal Slack link.
Changed
.circleci/config.ymlin this repo to contain appropriate configuration to enable Gitleaks as a CI check.