Revert default value validation of input fields and arguments #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns out to break enough existing schemas (Router rejects them as invalid where it previously accepted them) that we consider it a breaking change. See #928
goto-bus-stop
approved these changes
Nov 25, 2024
crates/apollo-compiler/CHANGELOG.md
Outdated
| @@ -21,7 +21,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|
|||
| ## Fixes | |||
| - **Validate against reserved names starting with `__` in schemas - [SimonSapin], [pull/923].** | |||
| - **Validate the default value of input fields and arguments - [SimonSapin], [pull/925].** | |||
| - **Fix duplicate diagnostic for variable with invalid default value - [SimonSapin], [pull/925].** | |||
There was a problem hiding this comment.
maybe add this PR to the changelog entry too? if someone looks at 925 alone they might get the wrong impression
% Conflicts: % crates/apollo-compiler/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns out to break enough existing schemas (Router rejects them as invalid where it previously accepted them) that we consider it a breaking change.
See #928