Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #762

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[email protected] #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b02267a
[email protected]
goto-bus-stop Nov 30, 2023
53b9e8e
add colon
goto-bus-stop Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions crates/apollo-compiler/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
## Maintenance
## Documentation-->

# [x.x.x] (unreleased) - 2023-mm-dd
# [1.0.0-beta.8](https://crates.io/crates/apollo-compiler/1.0.0-beta.8) - 2023-11-30

## BREAKING

Expand Down Expand Up @@ -137,26 +137,25 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
schema { query: MyQuery }
```

[SimonSapin]: https://github.com/SimonSapin
[issue/709]: https://github.com/apollographql/apollo-rs/issues/709
[issue/751]: https://github.com/apollographql/apollo-rs/issues/751
[pull/724]: https://github.com/apollographql/apollo-rs/pull/724
[pull/752]: https://github.com/apollographql/apollo-rs/pull/752
[pull/760]: https://github.com/apollographql/apollo-rs/pull/760

## Fixes

- **Limit recursion in validation - [goto-bus-stop], [pull/748] fixing [issue/742]**
- **Limit recursion in validation - [goto-bus-stop], [pull/748] fixing [issue/742]:**
Validation now bails out of very long chains of definitions that refer to each other,
even if they don't strictly form a cycle. These could previously cause extremely long validation
times or stack overflows.

The limit for input objects and directives is set at 32. For fragments, the limit is set at 100.
Based on our datasets, real-world documents don't come anywhere close to this.

[SimonSapin]: https://github.com/SimonSapin
[goto-bus-stop]: https://github.com/goto-bus-stop
[issue/709]: https://github.com/apollographql/apollo-rs/issues/709
[issue/742]: https://github.com/apollographql/apollo-rs/issues/742
[issue/751]: https://github.com/apollographql/apollo-rs/issues/751
[pull/724]: https://github.com/apollographql/apollo-rs/pull/724
[pull/748]: https://github.com/apollographql/apollo-rs/pull/748
[pull/752]: https://github.com/apollographql/apollo-rs/pull/752
[pull/760]: https://github.com/apollographql/apollo-rs/pull/760

# [1.0.0-beta.7](https://crates.io/crates/apollo-compiler/1.0.0-beta.7) - 2023-11-17

Expand Down
2 changes: 1 addition & 1 deletion crates/apollo-compiler/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "apollo-compiler"
version = "1.0.0-beta.7" # When bumping, also update README.md
version = "1.0.0-beta.8" # When bumping, also update README.md
authors = ["Irina Shestak <[email protected]>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/apollographql/apollo-rs"
Expand Down
2 changes: 1 addition & 1 deletion crates/apollo-compiler/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Or add this to your `Cargo.toml` for a manual installation:
# Just an example, change to the necessary package version.
# Using an exact dependency is recommended for beta versions
[dependencies]
apollo-compiler = "=1.0.0-beta.7"
apollo-compiler = "=1.0.0-beta.8"
```

## Rust versions
Expand Down
2 changes: 1 addition & 1 deletion crates/apollo-smith/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ categories = [
]

[dependencies]
apollo-compiler = { path = "../apollo-compiler", version = "=1.0.0-beta.7" }
apollo-compiler = { path = "../apollo-compiler", version = "=1.0.0-beta.8" }
apollo-parser = { path = "../apollo-parser", version = "0.7.0" }
arbitrary = { version = "1.3.0", features = ["derive"] }
indexmap = "2.0.0"
Expand Down