-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add reactiveVars persistence options #7148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PedroBern
wants to merge
11
commits into
apollographql:main
Choose a base branch
from
PedroBern:feat-reactive-vars-storage-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+105
−5
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f315c7c
feat: reactiveVars storage options
PedroBern c5455e1
Merge branch 'main' into feat-reactive-vars-storage-options
PedroBern d485704
docs: reactiveVars persistence options
PedroBern 066dac8
docs: restore reacive vars example
PedroBern 5f5c8b5
docs: restore reactiveVars example
PedroBern 87b7e38
Merge remote-tracking branch 'origin/feat-reactive-vars-storage-optio…
PedroBern b2e4ee7
fix: typo
PedroBern 40bdb1e
fix: circleCI max size
PedroBern f922c95
fix: circleCI max size
PedroBern 1e0dd96
fix: typo
PedroBern 79b1889
Merge branch 'main' into feat-reactive-vars-storage-options
PedroBern File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { isString } from '../isString'; | ||
|
||
describe('isString', () => { | ||
it('should identify strings', () => { | ||
const someString = isString("somestring") | ||
const notStrings = [{}, [], 0, undefined,null] | ||
|
||
expect(someString).toEqual(true); | ||
notStrings.forEach(f => expect(isString(f)).toEqual(false)); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export function isString(value: any) { | ||
return Object.prototype.toString.call(value) === '[object String]' | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.