Skip to content

Conversation

@sbatson5
Copy link
Contributor

@sbatson5 sbatson5 commented Nov 7, 2025

What's in this PR?

Add explanation for handling GraphQL errors in optimistic updates. It wasn't obvious what happens when a mutation fails and error is returned from the server. Adding one extra item in the lifecycle explanation makes it much clearer what happens

Add explanation for handling GraphQL errors in optimistic updates. It wasn't obvious what happens when a mutation fails and error is returned from the server. Adding one extra item in the lifecycle explanation makes it much clearer what happens
@sbatson5 sbatson5 requested a review from a team as a code owner November 7, 2025 20:57
@apollo-cla
Copy link

@sbatson5: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: 601039c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sbatson5 sbatson5 changed the title Document handling of GraphQL errors in optimistic UI Document optimisticResponse handling of GraphQL errors in optimistic UI Nov 7, 2025
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion to use active voice, but otherwise looks great! Thanks for the contribution!

@jerelmiller jerelmiller merged commit 6914a97 into apollographql:main Nov 14, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants