Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove itAsync from remaining relevant tests #12210

Open
wants to merge 5 commits into
base: jerel/remove-itasync-part-2
Choose a base branch
from

Conversation

jerelmiller
Copy link
Member

This PR completes the work to remove itAsync from our tests. It is still used by the hoc and component tests, but these will be deleted with 4.0 so we can ignore these for now. itAsync will be removed when we remove the query components and hoc on the 4.0 branch.

@jerelmiller jerelmiller requested a review from phryneas December 12, 2024 04:55
@svc-apollo-docs
Copy link

svc-apollo-docs commented Dec 12, 2024

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch jerel/remove-itasync-part-2 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch version-2.6
  • !docs set-base-branch main

Build ID: 9a8a8afe7a13708e524ee01d

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 79f6e3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 12, 2024

npm i https://pkg.pr.new/@apollo/client@12210

commit: 79f6e3d

@jerelmiller jerelmiller force-pushed the jerel/remove-itasync-part-2 branch from c976713 to 6c82bf7 Compare December 12, 2024 17:48
@jerelmiller jerelmiller force-pushed the jerel/remove-itasync-part-2 branch from 6c82bf7 to f2defe9 Compare January 8, 2025 01:08
@jerelmiller jerelmiller force-pushed the jerel/remove-itasync-part-3 branch from 1e7d108 to 5bdd9db Compare January 8, 2025 01:14
@jerelmiller jerelmiller force-pushed the jerel/remove-itasync-part-2 branch from f2defe9 to ba16e3d Compare January 8, 2025 01:28
@jerelmiller jerelmiller force-pushed the jerel/remove-itasync-part-3 branch 2 times, most recently from df1bc72 to 1ca4f08 Compare January 8, 2025 01:41
@jerelmiller jerelmiller force-pushed the jerel/remove-itasync-part-3 branch from 1ca4f08 to 79f6e3d Compare January 10, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants