-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user display name from user.userID to user.name #5213
Conversation
WalkthroughThe changes involve updating the user identifier displayed in the role management interface from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apollo-portal/src/main/resources/static/namespace/role.html (5 hunks)
Additional comments not posted (4)
apollo-portal/src/main/resources/static/namespace/role.html (4)
77-77
: LGTM!The change from
user.userId
touser.name
improves the user interface by displaying the user's name instead of their user ID.The code changes are approved.
89-89
: LGTM!The change from
user.userId
touser.name
improves the user interface by displaying the user's name instead of their user ID.The code changes are approved.
126-126
: LGTM!The change from
user.userId
touser.name
improves the user interface by displaying the user's name instead of their user ID.The code changes are approved.
139-139
: LGTM!The change from
user.userId
touser.name
improves the user interface by displaying the user's name instead of their user ID.The code changes are approved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5213 +/- ##
============================================
+ Coverage 50.30% 50.35% +0.05%
- Complexity 2013 2017 +4
============================================
Files 388 388
Lines 12228 12234 +6
Branches 1209 1209
============================================
+ Hits 6151 6161 +10
+ Misses 5712 5708 -4
Partials 365 365 ☔ View full report in Codecov by Sentry. |
I have read the CLA Document and I hereby sign the CLA |
What's the purpose of this PR
Fix user name display issue
Which issue(s) this PR fixes:
Fixes #
Brief changelog
change user display name from user.userID to user.name
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.Summary by CodeRabbit