Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some misc fix #5037

Merged
merged 1 commit into from
Dec 10, 2023
Merged

some misc fix #5037

merged 1 commit into from
Dec 10, 2023

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

misc fix

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 10, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01b0232) 49.61% compared to head (c391171) 49.62%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5037   +/-   ##
=========================================
  Coverage     49.61%   49.62%           
- Complexity     1903     1908    +5     
=========================================
  Files           372      372           
  Lines         11559    11559           
  Branches       1127     1127           
=========================================
+ Hits           5735     5736    +1     
+ Misses         5483     5481    -2     
- Partials        341      342    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nobodyiam nobodyiam merged commit 06fcb2a into apolloconfig:master Dec 10, 2023
11 checks passed
@nobodyiam nobodyiam deleted the 220-misc-fix branch December 10, 2023 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant