Solved some implementation and design smells #5023
Conversation
…service/AdditionalUserInfoEnrichService.java
…service/AdditionalUserInfoEnrichServiceImpl.java
…service/AdditionalUserInfoEnrichService
…service/AdditionalUserInfoEnrichServiceImpl
…rk/apollo/audit/aop/ApolloAuditSpanAspect.java
…rk/apollo/audit/aop directory
…dto/CommitDTO.java
…dto/GrayReleaseRuleDTO.java
…dto/NamespaceDTO.java
…dto/ReleaseDTO.java
…dto/ReleaseHistoryDTO.java
dosubot
bot
added
the
size:XXL
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
| fieldName = ((ApolloAuditLogDataInfluenceTableField) annotations[j]).fieldName(); | ||
| } | ||
| } | ||
| String[] strings= entityAndField(annotations); |
There was a problem hiding this comment.
Would you please help to explain what the code smell was?
|
|
||
| protected String dataChangeCreatedBy; | ||
|
|
||
| protected String namespaceName; |
There was a problem hiding this comment.
Why is namespaceName added here?
| import org.springframework.web.context.request.ServletRequestAttributes; | ||
|
|
||
| @Aspect | ||
| public class ApolloAuditSpanAspect { |
| @@ -109,17 +109,17 @@ public void testWhenHasReleaseMsgAndHasRepeatMsg() throws Exception { | |||
| assertEquals(3, latestReleaseMsg.getId()); | |||
| assertEquals(anotherMsgContent, latestReleaseMsg.getMessage()); | |||
|
|
|||
| List<ReleaseMessage> latestReleaseMsgGroupByMsgContent = | |||
| List<ReleaseMessage> groupedLatestMsgs = | |||
There was a problem hiding this comment.
Why was the variable renamed?
| <T> void enrichAdditionalUserInfo(List<? extends T> list, | ||
| Function<? super T, ? extends UserInfoEnrichedAdapter> mapper); | ||
|
|
||
| <T> List<UserInfoEnrichedAdapter> adapt(List<? extends T> dtoList, |
There was a problem hiding this comment.
Why adding this methond to the interface?
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
What's the purpose of this PR
Have solved 3 design smells and 3 implementation smells as a part of our assignment
Which issue(s) this PR fixes:
Fixes # It resolves design smells and implementation smells in different sections of the code.