Skip to content

Conversation

xzyfer
Copy link
Collaborator

@xzyfer xzyfer commented May 15, 2025

This would be a major version bump since fastify v5 has dropped support for Node < 20 forcing this packing to raise it's minimum supported version to Node 20.

Things to note:

  • fastify v5 is using the built-in NoInfer help so Typescript needed to be updated to >= 5.4
  • rimraf v5 is written in Typescript
  • fixed the type issues instead of ignoring them
  • inlined the tsconfig because the @oly_op/tsconfig package isn't property exporting the tsconfig.json
  • updated the circleci config because it was out of date and broken

Closes #297
Closes #299
Fixes: #296

cc @BlenderDude

@xzyfer xzyfer force-pushed the update-fastify-5 branch from 288beee to 51a834e Compare May 15, 2025 08:20
Copy link

codesandbox-ci bot commented May 15, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@xzyfer xzyfer force-pushed the update-fastify-5 branch from 49105e6 to db778a0 Compare May 15, 2025 08:40
@glasser
Copy link

glasser commented May 27, 2025

#296 (comment)

@xzyfer xzyfer changed the base branch from main to fastify-5-develop July 22, 2025 02:45
@xzyfer xzyfer merged commit 02a8c24 into apollo-server-integrations:fastify-5-develop Jul 22, 2025
1 check passed
xzyfer added a commit that referenced this pull request Aug 7, 2025
* Update to fastify v5

* Minimize diff

* Widen fastify support to ^5.3.0

* Fastify v5 requires Typescript >= 5.4

* Update circle matrix to reflect new support window

* Replace Node 16 and 18 references with Node 20

* Use tsx to fix postbuild script

* Try to update circleci

* Fix circleci and prettier

* Fix tsconfig resolution error and incompatible @apollo/server dependencies

* Fix prettier

* Remove @oly_op/tsconfig
xzyfer added a commit that referenced this pull request Aug 8, 2025
* Update to fastify v5

* Minimize diff

* Widen fastify support to ^5.3.0

* Fastify v5 requires Typescript >= 5.4

* Update circle matrix to reflect new support window

* Replace Node 16 and 18 references with Node 20

* Use tsx to fix postbuild script

* Try to update circleci

* Fix circleci and prettier

* Fix tsconfig resolution error and incompatible @apollo/server dependencies

* Fix prettier

* Remove @oly_op/tsconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for fastify 5
3 participants