Skip to content

Modernize setup - #57

Merged
fnesveda merged 9 commits into
mainfrom
chore/cleanup
Aug 21, 2026
Merged

Modernize setup#57
fnesveda merged 9 commits into
mainfrom
chore/cleanup

Conversation

@fnesveda

@fnesveda fnesveda commented Aug 21, 2026

Copy link
Copy Markdown
Member

There are no functional changes in this PR. It only modernizes the repository setup:

  • migrates from npm to pnpm
  • migrates from eslint to oxlint
  • migrates from jest to vitest
  • adds formatting with oxfmt
  • updates to Typescript v7
  • stops compiling the code (and commiting it), instead will just run TypeScript files directly in the action
  • adds automated releases with release-please
  • adds linting and testing in CI
  • moves tests to a separate directory
  • replaces axios with fetch

Some of the changes were much easier to do all at once (linting, testing, TS update, file structure change) and it would be a pain in the ass to separate them in multiple PRs, therefore I've done them all at once (which makes the PR basically unreviewable).

Since there are no functional changes, and the PR works (because a workflow in it tries to run the action on top of the PR), I'll just merge it, sorry.

@fnesveda fnesveda self-assigned this Aug 21, 2026
@github-actions github-actions Bot added t-management Issues with this label belong to the CTO or engineering managers. tested Temporary label used only programatically for some analytics. labels Aug 21, 2026
@fnesveda fnesveda added the adhoc Ad-hoc unplanned task added during the sprint. label Aug 21, 2026
@fnesveda
fnesveda merged commit d66ec11 into main Aug 21, 2026
4 checks passed
@fnesveda
fnesveda deleted the chore/cleanup branch August 21, 2026 14:40
@Mantisus

Mantisus commented Aug 21, 2026

Copy link
Copy Markdown

@fnesveda sorry, but after this PR the Apify pull request toolkit always fails for PRs from forks 🙂

https://github.com/apify/crawlee-python/actions/runs/32528650738/job/96916026658?pr=2158

@fnesveda

Copy link
Copy Markdown
Member Author

@Mantisus Ah, sorry, my bad. I've fixed it now: #59

And I re-ran the failed workflow on your PR and it went through now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-management Issues with this label belong to the CTO or engineering managers. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants