Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: website design uplift #2872

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Conversation

webrdaniel
Copy link
Collaborator

@webrdaniel webrdaniel commented Mar 5, 2025

Changes:

  • navigation header (different on index page and javascript pages)
  • footer
  • search modal
  • new index page
  • new /js page

Note:
It is not possible to navigate to the /python page when running localy as it lives in different repo.

TODO:
I have not found which links to use for the buttons on the landing page and header, so I just used some that make sense to me. But please check if they are really correct.

Figma design files are here

Content file: https://www.notion.so/apify/Crawlee-homepage-value-props-12af39950a2280d29d20edb080b2ece9?pvs=4

@github-actions github-actions bot added this to the 109th sprint - Web Team milestone Mar 5, 2025
@github-actions github-actions bot added the t-web Issues with this label are in the ownership of the web team. label Mar 5, 2025
Closes apify/apify-web#4504

---------

Co-authored-by: katzino <[email protected]>
Co-authored-by: Daniel Wébr <[email protected]>
@webrdaniel webrdaniel marked this pull request as ready for review March 6, 2025 15:18
@webrdaniel webrdaniel requested review from baldasseva and rezaczu March 6, 2025 15:19
@webrdaniel webrdaniel requested a review from diodames March 7, 2025 10:40
@diodames
Copy link

diodames commented Mar 7, 2025

Hey, great work!
Few things. The code snippet horizontal scroll seems unnecessary (attached screenshot).
Screenshot 2025-03-07 at 11 44 25

On the /Javascript page the code snippet of the benefits seems the spacing of the elements inside is a bit too much.
Screenshot 2025-03-07 at 11 44 54

Probably similar issue below it (attached), can we not have it scrollable maybe so the code fits the text area?
Screenshot 2025-03-07 at 11 46 02

@diodames
Copy link

diodames commented Mar 7, 2025

One more thing that I noticed, it seems like when I click on the menu it's hard to read the text (attached) screenshot, not sure why I see it that way. Specifically the /Javascript and /Python
Screenshot 2025-03-07 at 11 47 44

@webrdaniel
Copy link
Collaborator Author

Updated the code blocks by decreasing the paddings and spacings.
Unfortunetely those does not support wrapping the text to the next line to prevent the scrolling.
We can add some custom css but it wont look good because of the various indents.

@katzino
Copy link
Collaborator

katzino commented Mar 7, 2025

Logo dropdown jumps during initial page laod

Screen.Recording.2025-03-07.at.13.16.47.mov

@katzino
Copy link
Collaborator

katzino commented Mar 7, 2025

Those circles get shrunk by 2px

Screen.Recording.2025-03-07.at.13.19.59.mov

@katzino
Copy link
Collaborator

katzino commented Mar 7, 2025

This shouldn't be full width button
Screenshot 2025-03-07 at 13 21 32

Copy link

@rezaczu rezaczu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 nits so far 🤓

  1. Sometimes when I return to the Crawlee homepage, the content is misaligned and it takes a while for it to load (probably because of the animation at the bottom?)
Screen.Recording.2025-03-07.at.14.48.06.mov
  1. Clicking on the Crawlee dropdown scrolls me to the top of the current page. I think it should not do that. 🙈 Also if you try to open a page you are already on, the dropdown stays open, I think it would be handy to just close it, but maybe scroll to the top? 🧹
Screen.Recording.2025-03-07.at.14.53.18.mov

Nothing seems too broken though! 😁

@webrdaniel
Copy link
Collaborator Author

@rezaczu did some fixes. It would be quite hard to do the closing menu if clicking on the item you are currently on, so I left that is it is.

@katzino
Copy link
Collaborator

katzino commented Mar 10, 2025

super nit, but there is an inconsistency in how boolean value is highlighted 🧐
Screenshot 2025-03-10 at 10 22 28
Screenshot 2025-03-10 at 10 22 16

@B4nan
Copy link
Member

B4nan commented Mar 10, 2025

regarding this particular example, nowadays you can as well use string literals instead of the enum values to make it less wide

fingerprintOptions: {
    fingerprintGeneratorOptions: {
        operatingSystems: ['windows'],
        browsers: ['chrome'],
        devices: ['desktop'],
    },
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-web Issues with this label are in the ownership of the web team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants