Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: await on browser pool _createpageforbrowser #2860

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: await on browser pool _createpageforbrowser #2860

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35576a4
await on browser pool _createpageforbrowser
theanuragg Feb 25, 2025
2d8e31b
race conditions from concurrent calls
theanuragg Feb 25, 2025
9c14b6e
code aligns properly
theanuragg Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/browser-pool/src/browser-pool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ export class BrowserPool<
browserController = await this._launchBrowser(id, { browserPlugin, proxyTier, proxyUrl });
tryCancel();

return this._createPageForBrowser(id, browserController, pageOptions, proxyUrl);
return await this._createPageForBrowser(id, browserController, pageOptions, proxyUrl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i am also not convinced this can help, the inner function was also async, returning from inside an async function is enough.

});
}

Expand All @@ -471,7 +471,7 @@ export class BrowserPool<

const browserController = await this._launchBrowser(id, { launchOptions, browserPlugin });
tryCancel();
return this._createPageForBrowser(id, browserController, pageOptions);
return await this._createPageForBrowser(id, browserController, pageOptions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see how this could have any effect, the method is async, this wasn't an ignored promise (and if it was, the issue was on a higher level)

}

/**
Expand Down
Loading