Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,6 @@ async def get_request(self, unique_key: str) -> Request | None:
logger.warning(f'Request with unique key "{unique_key}" not found in the queue.')
return None

state = self._state.current_value
state.in_progress_requests.add(request.unique_key)
await self._update_metadata(update_accessed_at=True)
return request

Expand Down
14 changes: 14 additions & 0 deletions tests/unit/storage_clients/_file_system/test_fs_rq_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,3 +173,17 @@ async def test_data_persistence_across_reopens() -> None:
assert {request1.url, request2.url} == {'https://example.com/1', 'https://example.com/2'}

await reopened_client.drop()


async def test_get_request_does_not_mark_in_progress(rq_client: FileSystemRequestQueueClient) -> None:
"""Test that get_request does not block a request from being fetched."""
request = Request.from_url('https://example.com/blocked')
await rq_client.add_batch_of_requests([request])

fetched = await rq_client.get_request(request.unique_key)
assert fetched is not None
assert fetched.unique_key == request.unique_key

next_request = await rq_client.fetch_next_request()
assert next_request is not None
assert next_request.unique_key == request.unique_key
Loading