Skip to content

feat(bin): don't test on nonfunctional changes in json files#56

Open
metalwarrior665 wants to merge 3 commits intomasterfrom
feat/skip-nonfunctional-changes
Open

feat(bin): don't test on nonfunctional changes in json files#56
metalwarrior665 wants to merge 3 commits intomasterfrom
feat/skip-nonfunctional-changes

Conversation

@metalwarrior665
Copy link
Member

Was mostly vibecoded :)

resolves #54

@metalwarrior665 metalwarrior665 requested a review from oklinov March 4, 2026 23:19
@metalwarrior665 metalwarrior665 requested review from Patai5 and oklinov and removed request for Patai5 and oklinov March 5, 2026 15:05
Copy link
Contributor

@ruocco-l ruocco-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metalwarrior665
Copy link
Member Author

Thanks for the review. I will wait for @oklinov since he will return shortly.

I also want to do unify the naming of changes a bit, I'm thinking 3 types:

  • functional (test)
  • cosmetic (release only)
  • ignored (just dev only stuff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't run tests on non-functional changes (e.g. decription)

2 participants