Skip to content

chore: Add test server and some top level crawler tests #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

chore: Add test server and some top level crawler tests #517

wants to merge 7 commits into from

Conversation

Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Jul 25, 2025 •
edited
Loading

Description

  • add a simple TestServer for the integration tests
  • add three new tests focused on top-level crawler usage of RequestQueue related arguments.

@github-actions github-actions bot added this to the 119th sprint - Tooling team milestone Jul 25, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Jul 25, 2025
@Pijukatel Pijukatel changed the title Add test server and some top level Crawler tests Add test server and some top level crawler tests Jul 28, 2025
@Pijukatel Pijukatel changed the title Add test server and some top level crawler tests chore: Add test server and some top level crawler tests Jul 28, 2025
@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Jul 28, 2025
@Pijukatel Pijukatel marked this pull request as ready for review July 28, 2025 14:35
@Pijukatel Pijukatel requested a review from vdusek July 28, 2025 14:35
vdusek
vdusek requested changes Jul 28, 2025
View reviewed changes
pyproject.toml Outdated
Comment on lines 39 to 47
"crawlee~=0.6.0",
"crawlee[parsel]~=0.6.0",
"cryptography>=42.0.0",
"httpx>=0.27.0",
# TODO: ensure compatibility with the latest version of lazy-object-proxy
# https://github.com/apify/apify-sdk-python/issues/460
"lazy-object-proxy<1.11.0",
"more_itertools>=10.2.0",
"typing-extensions>=4.1.0",
"uvicorn[standard]~=0.35.0",
Copy link
Contributor

@vdusek vdusek Jul 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev dependency group? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

vdusek
vdusek reviewed Jul 28, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And warning:

  /home/runner/work/apify-sdk-python/apify-sdk-python/tests/integration/actor_source_base/test_server.py:63: PytestCollectionWarning: cannot collect test class 'TestServer' because it has a __init__ constructor (from: tests/integration/actor_source_base/test_server.py)
    class TestServer(Server):

@Pijukatel Pijukatel requested a review from vdusek July 29, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek Awaiting requested review from vdusek

Requested changes must be addressed to merge this pull request.

Assignees

@Pijukatel Pijukatel

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
119th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@Pijukatel @vdusek