Skip to content

chore: migrate to oxfmt#2494

Merged
B4nan merged 3 commits intomasterfrom
chore/migrate-to-oxfmt
May 5, 2026
Merged

chore: migrate to oxfmt#2494
B4nan merged 3 commits intomasterfrom
chore/migrate-to-oxfmt

Conversation

@B4nan
Copy link
Copy Markdown
Member

@B4nan B4nan commented May 4, 2026

Summary

Adds oxfmt as the formatter, matching the toolchain in apify-storage-local-js, apify-shared-js, apify-core, apify-web, apify-client-js, apify-sdk-js, actor-scraper, and crawlee v4. The repo had no formatter before — this is a fresh adoption.

Stacked on top of #2493 (eslint→oxlint migration). Will be retargeted to `master` once the parent merges.

Commits

  • `chore: add oxfmt tooling` — adds `oxfmt@0.46.0` devDep, `.oxfmtrc.json` (4-space tabs, single quotes, 120 col), and `format` / `format:check` scripts
  • `chore: apply oxfmt formatting` — pure `oxfmt --write` reformat across 219 files (mostly `.css`, `.html`, `.js`/`.jsx`, `.ts`/`.tsx`, `.mjs`)
  • `ci: add format-check step` — gates the lint job on `pnpm format:check`

Test plan

  • `pnpm lint:code` — clean
  • `pnpm format:check` — clean

Follow-up

Once this lands, add the reformat commit SHA to `.git-blame-ignore-revs` so blame skips it.

@B4nan B4nan added the adhoc Ad-hoc unplanned task added during the sprint. label May 4, 2026
@B4nan B4nan force-pushed the chore/migrate-to-oxfmt branch 2 times, most recently from e233ff9 to 76c8726 Compare May 4, 2026 14:52
Copy link
Copy Markdown
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions, nothing major

Comment thread .oxfmtrc.json
Comment thread .oxfmtrc.json Outdated
@B4nan B4nan force-pushed the chore/migrate-to-oxfmt branch from 76c8726 to 37901c3 Compare May 4, 2026 15:25
Base automatically changed from chore/migrate-to-oxlint to master May 5, 2026 06:38
@B4nan B4nan force-pushed the chore/migrate-to-oxfmt branch from 37901c3 to 5608b2c Compare May 5, 2026 07:08
Copy link
Copy Markdown
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@B4nan B4nan force-pushed the chore/migrate-to-oxfmt branch from 5608b2c to 270efe1 Compare May 5, 2026 09:19
@github-actions github-actions Bot added this to the 140th sprint - Tooling team milestone May 5, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label May 5, 2026
@B4nan B4nan merged commit 034920a into master May 5, 2026
15 checks passed
@B4nan B4nan deleted the chore/migrate-to-oxfmt branch May 5, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants