Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: third lesson about DevTools #1321

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: third lesson about DevTools #1321

wants to merge 8 commits into from

Conversation

honzajavorek
Copy link
Collaborator

@honzajavorek honzajavorek commented Dec 6, 2024 •
edited
Loading

Porting this lesson and this lesson:

  • I deliberately didn't include anything about cleaning data or iterating over the data, because it would be unnecessary load of JavaScript for a Python dev, for no obvious reason. They'll learn everything in the following lessons. I focused only on stuff which can be considered as ad-hoc inspection of the website, which is useful even to Python devs.
  • I tried to unify the style with the rest of the course. I wrote the stuff with my own words, and added standard polishing I usually do (dictionary, proofreading by AI, etc.)
  • I added several screenshots.
  • I added exercises.
  • There's no Python, so I'm not bothering Vláďa with this one.

image

@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Dec 6, 2024
@honzajavorek honzajavorek mentioned this pull request Dec 6, 2024
Open
19 tasks
@honzajavorek honzajavorek force-pushed the honzajavorek/py-devtools3 branch from 4bd5048 to 5453900 Compare January 21, 2025 09:11
@honzajavorek
Copy link
Collaborator Author

In 94b26f5 I added ul to the dictionary, because Vale wasn't happy otherwise, but I think we should set it up so that it's able to skip inline code blocks. It didn't have problems with any other inline code, so I'm not sure what's the problem - perhaps it's even a bug in Vale we should report back?

Screenshot 2025-01-21 at 15 01 49

@honzajavorek honzajavorek marked this pull request as ready for review January 21, 2025 14:07
@honzajavorek honzajavorek force-pushed the honzajavorek/py-devtools3 branch from 94b26f5 to a2f4466 Compare January 21, 2025 14:07
@mnmkng
Copy link
Member

mnmkng commented Feb 10, 2025

Hey guys, I'm sorry, but I find it really hard to find the time for the reviews. If @metalwarrior665 can't do them reasonably fast, then we need to find someone else to chip in.

Perhaps @souravjain540?

It's a shame that this great content gets stuck here for so long.

@metalwarrior665
Copy link
Member

I didn't know we were even blocking these PRs on reviews. I have done some work in the JS space recently and I would definitely want to review any change there. For Python I think @souravjain540 would make sense

@souravjain540
Copy link
Contributor

guys, I am sorry I can't promise to give my best reviews in such a busy schedule right now, considering there are really high priority time bounded projects like: the OS fair share program, PyCon Namibia: Workshop and Talk, Actor Bounty Program, PPE, and all my regular content tasks of Crawlee and others.

I can come back to give reviews after PyCon Namibia if that's okay.

@honzajavorek
Copy link
Collaborator Author

As of now I'm in no rush with this one, I got stuck on other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnmkng mnmkng Awaiting requested review from mnmkng

@metalwarrior665 metalwarrior665 Awaiting requested review from metalwarrior665

@TC-MO TC-MO Awaiting requested review from TC-MO

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
t-academy Issues related to Web Scraping and Apify academies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@honzajavorek @mnmkng @metalwarrior665 @souravjain540