Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add log() method to BuildClient (JS) #509

Merged
merged 2 commits into from
Feb 14, 2024
Merged

feat: add log() method to BuildClient (JS) #509

merged 2 commits into from
Feb 14, 2024

Conversation

tobice
Copy link
Contributor

@tobice tobice commented Feb 9, 2024 •
edited
Loading

This wraps the new /actor-builds/<BUILD_ID>/log API.

@tobice
feat: add log() method to BuildClient
54e6c40 
This wraps the new `/actor-builds/<BUILD_ID>/log` API.
@github-actions github-actions bot added this to the 82nd sprint - Platform team milestone Feb 9, 2024
@github-actions github-actions bot added t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. labels Feb 9, 2024
@tobice tobice changed the title feat: add log() method to BuildClient DRAFT: feat: add log() method to BuildClient Feb 9, 2024
@tobice tobice changed the title DRAFT: feat: add log() method to BuildClient DRAFT: feat: add log() method to BuildClient and ActorClient? Feb 9, 2024
@tobice tobice changed the title DRAFT: feat: add log() method to BuildClient and ActorClient? feat: add log() method to BuildClient Feb 9, 2024
@tobice tobice marked this pull request as ready for review February 9, 2024 10:49
@tobice tobice requested review from fnesveda and drobnikj February 9, 2024 10:49
@tobice
Copy link
Contributor Author

tobice commented Feb 9, 2024

I guess this shouldn't be merged / released before the API is actually updated? https://github.com/apify/apify-core/pull/14281

@fnesveda
Copy link
Member

fnesveda commented Feb 9, 2024

I guess this shouldn't be merged / released before the API is actually updated? apify/apify-core#14281

Yep, and until the API reference is updated too.

fnesveda
fnesveda approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@tobice
Copy link
Contributor Author

tobice commented Feb 9, 2024 •
edited
Loading

Keeping this on hold before the API is merged and released in https://github.com/apify/apify-core/pull/14281.

drobnikj
drobnikj approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@drobnikj drobnikj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobice tobice changed the title feat: add log() method to BuildClient feat: add log() method to BuildClient (JS) Feb 13, 2024
@tobice tobice merged commit 8821df6 into master Feb 14, 2024
6 checks passed
@tobice tobice deleted the tobik/feat/add-log-methods-to-api branch February 14, 2024 10:38
@drobnikj drobnikj added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnesveda fnesveda fnesveda approved these changes

@drobnikj drobnikj drobnikj approved these changes

Assignees

@tobice tobice

Labels
t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
82nd sprint - Platform team
Development

Successfully merging this pull request may close these issues.
3 participants
@tobice @fnesveda @drobnikj