Skip to content

Conversation

vladfrangu
Copy link
Member

This PR:

  • moves us to the split inquirer modules, so we only import what we need, and not allll the different variants of inquirer
  • makes yes/no questions not require an extra enter press for confirmation, you just press y, or n (enter key will use default, any other key is ignored)
  • ensures we only prompt if we have stdin available somehow (this should prevent tests hanging in CI if that ever happens to repeat), and provide ways to pass it from flags (especially once we pick a common flag name, right now we have... --yes, --no-prompt.......)
  • ever so slightly smaller bundles are always nice

@vladfrangu vladfrangu requested a review from B4nan as a code owner July 29, 2025 14:28
@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label Jul 29, 2025
@github-actions github-actions bot added this to the 120th sprint - Tooling team milestone Jul 29, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Jul 29, 2025
Comment on lines +30 to +31
"assist": {
"enabled": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this doing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns off biome's importer sorter too since that has constantly caused me issues and code that just broke

@vladfrangu vladfrangu merged commit 0e63480 into master Aug 4, 2025
24 checks passed
@vladfrangu vladfrangu deleted the chore/inquirer-upgrade branch August 4, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants