Skip to content

Send unified and legacy CLI telemetry events#1133

Open
patrikbraborec wants to merge 2 commits into
masterfrom
fix/dual-command-telemetry-events
Open

Send unified and legacy CLI telemetry events#1133
patrikbraborec wants to merge 2 commits into
masterfrom
fix/dual-command-telemetry-events

Conversation

@patrikbraborec
Copy link
Copy Markdown
Contributor

Summary

  • emit the new unified cli_command telemetry event for every CLI command
  • keep emitting the legacy per-command events such as cli_command_push for backward compatibility
  • send both telemetry events independently with Promise.allSettled so one failure does not block the other
  • add focused coverage for both event names and the shared commandString payload

Closes #1132

Testing

  • corepack pnpm vitest run test/local/lib/command-framework/telemetry-event-name.test.ts
  • git diff --check

Note: corepack pnpm tsc --noEmit currently fails on an unrelated existing type error in src/lib/consts.ts: META_ORIGINS.CI is not present in the installed @apify/consts type.

@github-actions github-actions Bot added this to the 140th sprint - DX team milestone May 14, 2026
@github-actions github-actions Bot added t-dx Issues owned by the DX team. tested Temporary label used only programatically for some analytics. labels May 14, 2026
@patrikbraborec patrikbraborec force-pushed the fix/dual-command-telemetry-events branch from 64972d9 to 2662ac7 Compare May 14, 2026 11:58
@patrikbraborec patrikbraborec force-pushed the fix/dual-command-telemetry-events branch from cdc7ae6 to 1a3a821 Compare May 15, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-dx Issues owned by the DX team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure legacy CLI command telemetry is sent independently

2 participants