feat: better i18n for CLI#1087
Conversation
|
I think that the second option is better. Just a side note -> have you ever seen/used CLI that use different language than English? Or we will use English, and this is just better code convention to do it? |
|
I've seen Claude has several languages if I recall. I personally don't use anything but English but ik others might want it. That said I mostly wanted to have a structured way to define messages, maybe I can refactor it to drop locales and just have a way to define the 3 variants for messages (human, markdown and json) |
|
Do you think that we need difference for human vs markdown? Should not we have everything in md as it is quite easy format to read? |
a9926b9 to
00de5c4
Compare
82fa97b to
d418902
Compare
|
@vladfrangu thanks, it has +6k line of changes, it's probably hard to do any meaningful review. Maybe we can use staff review skill https://github.com/apify/agent-skills-internal/blob/main/skills/staff-review/SKILL.md to do at least something. |
Squashes the following work into a single commit so the rebase onto origin/master can resolve conflicts against the final state. - feat: locale utilities for messages - feat: new logger system - refactor: replace stream-based logger with LoggerOutput abstraction - fix(e2e): clear APIFY_NO_LOGS_IN_TESTS in CLI child process env - feat: make messages provide a markdown/json format instead - chore: simplify
So far this PR tackles a nicer logger interface than random imported functions across the project, and also lays the ground work for i18n support (both in formatting strings, using the ICU Message format).
I am ready to port all messages and write upgrades to CLAUDE.md and such, but I want to know where we want to store these localized messages
src/i18nand import where needed