Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add static analysis for Python templates #316

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Feb 18, 2025

Add static analysis (Ruff, Mypy) for Python templates.

Edit: Mypy will require further updates due to our usage of src/:

$ make type-check 
poetry run mypy
templates/python-crawlee-beautifulsoup/src/__init__.py: error: Duplicate module named "src" (also at "templates/python-beautifulsoup/src/__init__.py")
templates/python-crawlee-beautifulsoup/src/__init__.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
templates/python-crawlee-beautifulsoup/src/__init__.py: note: Common resolutions include: a) using `--exclude` to avoid checking one of them, b) adding `__init__.py` somewhere, c) using `--explicit-package-bases` or adjusting MYPYPATH
Found 1 error in 1 file (errors prevented further checking)
make: *** [Makefile:16: type-check] Error 2

This will be addressed later in #317.

@vdusek vdusek self-assigned this Feb 18, 2025
@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 18, 2025
@github-actions github-actions bot added this to the 108th sprint - Tooling team milestone Feb 18, 2025
@vdusek vdusek added infrastructure Issues related to infrastructure or CI/CD pipeline. adhoc Ad-hoc unplanned task added during the sprint. labels Feb 18, 2025
@vdusek
Copy link
Contributor Author

vdusek commented Feb 18, 2025

@jirispilka, @MQ37 feel free to check this out as well 🙂

@vdusek vdusek merged commit d09f9f9 into master Feb 18, 2025
18 of 21 checks passed
@vdusek vdusek deleted the add-static-analysis branch February 18, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. infrastructure Issues related to infrastructure or CI/CD pipeline. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants