FDN-3181 Publish scala2 version #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackl
commented
Jan 10, 2025
|
|
||
| final case class Service( | ||
| @deprecated("This field is no longer used in API Builder and may be removed in the future.") apidoc: _root_.scala.Option[io.apibuilder.spec.v0.models.Apidoc] = None, | ||
| // TODO - Hack to get around lack of -Wconf:src support in scalac 3.4.2 |
Contributor
Author
There was a problem hiding this comment.
This is obviously not ideal
mbryzek
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flowcommerce/api-builddepends on this library (v 0.52.0), and within it the definition forio.apibuilder.spec.v0.models.Servicehas theapidocfield as required. However the apibuilder api never returns it, for example in the BatchDownloadApplications endpoint, resulting in an error.I have deployed a kludge in apibuilder api to always return an apiDoc value for a Service model instance, and that has allowed
flowcommerce/api-buildto work again.