feat: implement reconciler for apisixroute #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-06-16T07:34:48Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
failedTests:
- HTTPRouteInvalidBackendRefUnknownKind
result: failure
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 1
Passed: 31
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests failed with 1 test failures. |
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-06-16T07:36:58Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
result: partial
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 0
Passed: 32
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests partially succeeded with 1 test skips. |
dspo
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new feature that implements the ApisixRoute reconciler along with several supporting changes. Key changes include the addition of a new SetApisixRouteConditionAccepted function, updates to the indexing functions for ApisixRoute resources, and systematic replacement of local NamespacedName calls with a centralized utility.
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/controller/utils.go | Added new constants and SetApisixRouteConditionAccepted function |
| internal/controller/* | Updated NamespacedName usages to use utils.NamespacedName |
| internal/controller/indexer/indexer.go | Added setupApisixRouteIndexer and associated index functions |
| docs/crd/api.md; config/crd/bases/.yaml; api/v2/ | Updated CRDs and API types to support APISIX v2 and new operator syntaxes |
Comments suppressed due to low confidence (2)
config/crd/bases/apisix.apache.org_apisixroutes.yaml:132
- The removal of the 'weight' field from the required fields in the service spec may be a breaking change for users relying on it. Please confirm that this change is intended and document the impact accordingly.
- - weight
api/v2/reason.go:1
- The removal of the entire api/v2/reason.go file could potentially affect references elsewhere if still in use. Please verify that this removal is intentional and that no dependencies rely on it.
// Licensed under the Apache License...
ronething
reviewed
Jun 16, 2025
ronething
reviewed
Jun 16, 2025
ronething
reviewed
Jun 16, 2025
ronething
reviewed
Jun 16, 2025
Comment on lines
152
to
160
| if !plugin.Enable { | ||
| continue | ||
| } | ||
| if plugin.Config == nil { | ||
| continue | ||
| } | ||
| if plugin.SecretRef == "" { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Merge into OR condition?
ronething
reviewed
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
实现 ApisixRoute Reconciler
Pre-submission checklist: