fix(apisix): store stream route name correctly #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pottekkat
approved these changes
Jul 20, 2024
pottekkat
approved these changes
Jul 20, 2024
juzhiyuan
approved these changes
Jul 20, 2024
| @@ -108,7 +108,7 @@ export interface StreamRoute { | |||
| id: string; | |||
| desc?: string; | |||
| labels?: Labels; | |||
| name: string; | |||
| //name: string; // As of 3.9.1, APISIX does not support name on the stream route | |||
There was a problem hiding this comment.
Should we remove this unused value?
There was a problem hiding this comment.
No, I will add it to APISIX. We can use it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Synchronization fails due to the fact that APISIX resources are non-standard, e.g. the stream route does not have a name field that can be used to store names.
This PR has some compatibility fixes, it uses
labelsto store a key called__ADC_NAMEto store the name, which is transparent to the user, and is automatically added during sync and removed during dump.I'm going to push for standardization of resource objects in APISIX, but until that's done, this compatibility measure is unavoidable.
Checklist