Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add lint on diff and sync in default #155

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Jul 20, 2024

Description

The current lint in the ADC is manual and will not be executed by default when diff and sync are executed, which can lead to unintended commit behavior, so this PR lists lint as a step in the diff and sync commands.

If you wish to turn off lint checking on diff and sync, you can use --no-lint to disable lint checking.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@bzp2010 bzp2010 marked this pull request as ready for review July 20, 2024 03:38
Copy link
Contributor

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bzp2010 bzp2010 merged commit d745ad4 into main Jul 20, 2024
6 checks passed
@bzp2010 bzp2010 deleted the bzp/feat-default-lint-check branch July 24, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants