Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct upstream numbers #127

Closed
wants to merge 1 commit into from
Closed

fix: correct upstream numbers #127

wants to merge 1 commit into from

Conversation

linzeyan
Copy link

Description

The number of upstream is wrong while executing adc validate, this pr corrected the upstream numbers in cmd/validate.go:99

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@CLAassistant
Copy link

CLAassistant commented May 14, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bzp2010
Copy link
Collaborator

bzp2010 commented Aug 9, 2024

The codebase has been significantly modified and it no longer uses Golang.
So I think the bug no longer exists.

I'm going to close this issue, and you can do a new test, if there are still errors, please open a new issue.

@bzp2010 bzp2010 closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants