fix: convert url variables to colon x #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the path variable in OpenAPI will be converted to *, its implementation on APISIX, which allows for arbitrary strings containing slash, which potentially doesn't fit our needs.
So this PR actually replaces variables like /order/{order_id} with /order/:order_id, which is more appropriate.
Specifically:
The original implementation:
While this does work, it will actually allow requests like this to be matched:
I.e., allowing
*
paths likexxx/xxx
to be matched, which could change the semantics of the URL and pose a security risk.Variables such as
:xxx
are not allowed to contain/
, i.e., they match at most one level of the directory on the URL.Checklist