Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix API7 EE CLI validation issues #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix API7 EE CLI validation issues #16
Changes from all commits
3aeb54111d5241f8e1a9b5cfa6277c2b80a9292695b48bde7e5be4d4671f6c7File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major | 🏗️ Heavy lift
SSLstruct must implementMarshalJSON()/String()redaction per coding guidelines — standalone helpers are opt-in only.SSL.Keyis a secret-bearing field. The standaloneRedactSSL/RedactSSLshelpers require every output site to explicitly opt in; any directjson.Marshal(ssl)call (e.g., in a future command, a logger, or afmt.Sprintf("%+v", ...)) silently leaks the private key.The coding guidelines mandate that the struct itself enforce redaction via
String(),MarshalJSON(), andMarshalLogObject()methods. The typical solution where the same struct is used for API writes (which need the real key) is to split into separate types — e.g. anSSLRequestfor API writes and anSSL/SSLResponsefor read/display — so thatMarshalJSON()on the display type always redacts.As per coding guidelines: "All secret-bearing structs must implement proper redaction in String(), MarshalJSON(), and MarshalLogObject() methods; verify pointer receiver vs value receiver matches."
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.