test: replace the deprecated bundle ApiTestCase in functional tests - #8557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now we had six functional tests added after the
api-platform/testextraction (#7887) that still extendedApiPlatform\Symfony\Bundle\Test\ApiTestCase, the shim that triggers a deprecation and extendsApiPlatform\Test\ApiTestCase.The deprecation fires when the file is loaded, outside of any test, so PHPUnit 12 never reports it, but PHPUnit 13.2+ does (sebastianbergmann/phpunit#6579) and the
phpunit-no-deprecationsjob fails once the constraint allows PHPUnit 13.This pull request is part of several fixes needed to enable PHPUnit 13 support in PR #8537.