fix(jsonapi): handle missing attributes in ErrorNormalizer #7569
+241
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daFish
force-pushed
the
fix/jsonapi-error-normalizer-missing-attributes
branch
from
7643871 to
87e290e
Compare
Fixes undefined array key warning when normalizing exceptions that don't have attributes in their normalized structure. This typically occurs with ItemNotFoundException when invalid resource identifiers are provided.
daFish
force-pushed
the
fix/jsonapi-error-normalizer-missing-attributes
branch
from
87e290e to
918e2fd
Compare
soyuka
requested changes
Dec 1, 2025
| @@ -0,0 +1,232 @@ | |||
| <?php | |||
Member
There was a problem hiding this comment.
tests are located in the component itself
Contributor
Author
There was a problem hiding this comment.
Oh, right. Will be moved.
| { | ||
| $jsonApiObject = $this->itemNormalizer->normalize($object, $format, $context); | ||
|
|
||
| if (!isset($jsonApiObject['data']['attributes'])) { |
Member
There was a problem hiding this comment.
how does this happen functionally? I'd love a functional reproducer inside tests/Functional/JsonApi
Contributor
Author
There was a problem hiding this comment.
I have the issue in my application and I'll come up with a functional test to highlight it.
| $this->assertEquals('An error occurred', $result['errors'][0]['title']); | ||
| $this->assertEquals('Something went wrong', $result['errors'][0]['detail']); | ||
| $this->assertIsString($result['errors'][0]['status']); | ||
| } |
Member
There was a problem hiding this comment.
these unit tests aren't providing useful additions in my opinion I'd rather not have them
Contributor
Author
There was a problem hiding this comment.
All of them or only testNormalizeWithValidStructure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes undefined array key warning when normalizing exceptions that don't have attributes in their normalized structure.
This typically occurs with ItemNotFoundException when invalid resource identifiers are provided.
Description
Fixes an undefined array key warning in
ErrorNormalizerwhen normalizing exceptions that don't have anattributeskey in their normalized structure.Problem
When
ItemNotFoundExceptionor similar exceptions are thrown for invalid resource identifiers, theErrorNormalizer::normalize()method assumes that$jsonApiObject['data']['attributes']exists, causing a warning.Solution
Added defensive checks to handle cases where the
attributeskey is not present, providing a fallback error structure that conforms to the JSON:API specification.