Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbtest patch 1 #445

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Carbtest patch 1 #445

wants to merge 4 commits into from

Conversation

carbtest
Copy link
Contributor

No description provided.

Deprecated: phpCAS::client(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead
@carbtest
Copy link
Contributor Author

carbtest commented Feb 13, 2025

These changes will fix: PHP8.4 issues
Deprecated: phpCAS::client(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/apereo/phpcas/source/CAS.php on line 348

Deprecated: phpCAS::proxy(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/apereo/phpcas/source/CAS.php on line 403

Deprecated: CAS_Client::__construct(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/apereo/phpcas/source/CAS/Client.php on line 933

@rutgers-master
Copy link

Really hope someone who has the ability to integrate this change will do so. Tested and confirmed it works with PHP 8.4. The changes are so simple...please someone release a phpCAS 1.6.2 version with these simple changes for PHP 8.4 support. It's been 3 months since PHP 8.4 was officially released and we all need this updated version with PHP 8.4 support.

@carbtest
Copy link
Contributor Author

carbtest commented Mar 5, 2025

Really hope someone who has the ability to integrate this change will do so. Tested and confirmed it works with PHP 8.4. The changes are so simple...please someone release a phpCAS 1.6.2 version with these simple changes for PHP 8.4 support. It's been 3 months since PHP 8.4 was officially released and we all need this updated version with PHP 8.4 support.

This repo is no longer maintained, we will have to fork it or modify our local version ;(

@rutgers-master
Copy link

rutgers-master commented Mar 6, 2025

From what I read here: https://groups.google.com/a/apereo.org/g/cas-user/c/7A4MKl6DIOk/m/WikoKAJ2AgAJ
They are still willing to review PRs... Fingers crossed someone does....

@rutgers-master
Copy link

We're going to try this after talking with the original developer of phpCAS who unfortunately stepped down and gave back all his privileges last year...

@phy25 Can you help us get this PR approved? Joachim said that you may still have commit privileges. You would make lots of people very happy if you could get this very simple change approved. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants