Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement EncryptedSharedPreferences #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuanbipa
Copy link

Change SharedPreferences to EncryptedSharedPreferences (Only supported for devices running on Android 6 or higher
)

@aparajita
Copy link
Owner

I don't think this is sufficient. If I'm not mistaken, this would render all existing data to be unreadable.

@lbrucher
Copy link

Hello, first off thank you both for the plugin and the PR :)
I understand that if we would merge that branch existing data would indeed not be readable anymore, which is not desirable.
An idea would be to keep the current implementation the default and add a new API method to allow users to use the EncryptedSharedPreferences instead.
Obviously that new API would only be making sense for Android but that does not seem like a show stopper to me.
What do you guys think?
Thanks!

@jimcase
Copy link

jimcase commented Nov 29, 2024

I just created a new PR continuing the work of @tuanbipa.
PR: #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants