-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pack integer arithmetic comparisons in IntCmpRule #1545
Conversation
Codecov Report
@@ Coverage Diff @@
## unstable #1545 +/- ##
============================================
+ Coverage 74.97% 75.00% +0.02%
============================================
Files 359 360 +1
Lines 11518 11526 +8
Branches 550 557 +7
============================================
+ Hits 8636 8645 +9
+ Misses 2882 2881 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
tla-bmcmt/src/main/scala/at/forsyte/apalache/tla/bmcmt/rules/EqRule.scala
Outdated
Show resolved
Hide resolved
tla-bmcmt/src/main/scala/at/forsyte/apalache/tla/bmcmt/rules/IntArithPacker.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Igor Konnov <[email protected]>
Closes #1342
Pack arithmetic expressions in
IntCmpRule
andEqRule
. Translate TLA+ arithmetic comparisons into a single SMT constraint, without introducing intermediate cells.Uses the same logic for packing arithmetic expressions as #1541, which is refactored into a trait in 835e717.